Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CRM-21535: Custom file upload field not showing up when Viewing Activity from Case Report. #11386

Merged
merged 2 commits into from
Dec 11, 2017
Merged

CRM-21535: Custom file upload field not showing up when Viewing Activity from Case Report. #11386

merged 2 commits into from
Dec 11, 2017

Conversation

agilewarealok
Copy link
Contributor

@agilewarealok agilewarealok commented Dec 7, 2017 •
edited by civicrm-builder
Loading

Overview

Steps to reproduce the bug:

  1. Create two custom fields, both of type file (Attachments) that use for Activities
  2. Create new case and upload files in those couple of fields.
  3. Open("View") the Last activity of type "Open Case"
  4. In the recent builds you can see the files, but two files are listed under both custom fields. Which is not correct, we should only see single file in front of each custom field. In previous builds the values doesn't show up at all.
  5. Click on edit activity icon, you can see both the files are attached separably on each custom field.

Before

Files displays multiple times or doesn't display at all, where as when viewing same activity from activity search page It's working as expected.

After

Files for each custom field gets display in front of them.

Agileware Ref: CIVICRM-754

@colemanw
Copy link
Member

colemanw commented Dec 7, 2017

I just pushed up a little cleanup to make the variable name make more sense. Other than that, looks good.
But we need a JIRA issue to link this to.

@jusfreeman
Copy link
Contributor

CiviCRM JIRA has been created for this bug fix, https://issues.civicrm.org/jira/browse/CRM-21535

Ready for review :)

@colemanw
Copy link
Member

Have tested it and it works great. Reproduced the bug as described, and fix is similar to one I did for another file display bug recently. Well done.

@agilewarealok agilewarealok changed the title CIVICRM-754: Custom file upload field not showing up when Viewing Activity from Case Report. CRM-21535: Custom file upload field not showing up when Viewing Activity from Case Report. Dec 11, 2017
@colemanw colemanw merged commit 76b75c5 into civicrm:master Dec 11, 2017
sluc23 pushed a commit to ixiam/civicrm-core that referenced this pull request Jan 10, 2018
@colemanw @sluc23
Merge pull request civicrm#11386 from agileware/CIVICRM-754
4509844 
CRM-21535: Custom file upload field not showing up when Viewing Activity from Case Report.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
master merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@agilewarealok @colemanw @jusfreeman @civicrm-builder